-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[bazel] Use zstd from the BCR #169146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[bazel] Use zstd from the BCR #169146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way if the downstream consuming project uses zstd we make sure they are dedup'd.
rupprecht
reviewed
Nov 24, 2025
rupprecht
reviewed
Nov 24, 2025
yzhang93
added a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 25, 2025
This reverts commit ac4cf40.
yzhang93
added a commit
to iree-org/iree
that referenced
this pull request
Nov 25, 2025
- Still carrying revert from last week llvm/llvm-project#162930. - Reverts related to bazel build: - llvm/llvm-project#169450 - llvm/llvm-project#169146 - llvm/llvm-project#168933 - llvm/llvm-project#168928 Signed-off-by: yzhang93 <[email protected]>
bangtianliu
pushed a commit
to bangtianliu/iree
that referenced
this pull request
Nov 25, 2025
- Still carrying revert from last week llvm/llvm-project#162930. - Reverts related to bazel build: - llvm/llvm-project#169450 - llvm/llvm-project#169146 - llvm/llvm-project#168933 - llvm/llvm-project#168928 Signed-off-by: yzhang93 <[email protected]>
yzhang93
added a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 25, 2025
This reverts commit ac4cf40.
yzhang93
added a commit
to iree-org/iree
that referenced
this pull request
Nov 26, 2025
Carrying reverts related to bazel build: - llvm/llvm-project#169450 - llvm/llvm-project#169146 - llvm/llvm-project#168933 - llvm/llvm-project#168928 Drop SLSR [revert](iree-org/llvm-project@e1cb8b4) in iree that is currently reverted in upstream. Signed-off-by: yzhang93 <[email protected]>
aadeshps-mcw
pushed a commit
to aadeshps-mcw/llvm-project
that referenced
this pull request
Nov 26, 2025
This way if the downstream consuming project uses zstd we make sure they are dedup'd. This uses a new rule to make sure layering_check still works while allowing us to augment the upstream library rules with LLVM specific `defines`.
lialan
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 26, 2025
This reverts commit ac4cf40.
lialan
added a commit
to iree-org/iree
that referenced
this pull request
Nov 26, 2025
Carrying reverts related to bazel build: - llvm/llvm-project#169450 - llvm/llvm-project#169146 - llvm/llvm-project#168933 - llvm/llvm-project#168928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way if the downstream consuming project uses zstd we make sure
they are dedup'd. This uses a new rule to make sure layering_check still
works while allowing us to augment the upstream library rules with LLVM
specific
defines.